fix(templates/arc): update README + dependencies
#2213
Conversation
|
Hi @ryanblock, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
| @@ -8,6 +8,7 @@ | |||
| "start": "cross-env NODE_ENV=production arc sandbox" | |||
There was a problem hiding this comment.
@mcansh: NODE_ENV=development is not required for any Architect processes, so in theory we can remove that from start + dev:arc if that doesn't cause any trouble for y'all!
There was a problem hiding this comment.
not 100% sure when we added that to the templates, but i'm 95% sure we set NODE_ENV during remix dev and remix build (and remix-serve)
There was a problem hiding this comment.
Ok, so do you want to leave it? Remove it? Arc is good either way, but imo always good to have less stuff if possible.
| @@ -8,6 +8,7 @@ | |||
| "start": "cross-env NODE_ENV=production arc sandbox" | |||
| }, | |||
| "dependencies": { | |||
| "@architect/architect": "^10.0.5", | |||
There was a problem hiding this comment.
How can we help ensure this is relatively up to date?
There was a problem hiding this comment.
couldn't we use ^10.x to signify any version of v10? we don't include lock files in the templates so once they're installed they should use the latest version available, no?
There was a problem hiding this comment.
otherwise, we can keep it ^10.0.5 and wait for PRs to bump the version when anything significant happens
There was a problem hiding this comment.
Yeah we can def safely set to 10.x
There was a problem hiding this comment.
^10.0.0 should indeed just work
|
|
||
| You will be running two processes during development when using Architect as your server. | ||
| ### TypeScript |
There was a problem hiding this comment.
Does all this make sense in the context of Remix? I know a lot of Remix + Arc folks have been trying to use TS, but have been a bit confused as to where to start, so I was thinking this might help shortcut them. Up to y'all!
There was a problem hiding this comment.
unfortunately using @architect/plugin-typescript for all lambdas causes a "lambda not found error" for the remix app, perhaps we can mention the config.arc approach instead? we might be able to tweak some remix config to make it work, I'll give it a shot soon
There was a problem hiding this comment.
lol wut, today it works - reason being i tried upgrading an existing app yesterday that wasnt using the new serverBuildTarget to bundle the app into the server directory so arc was then trying to compile it too
There was a problem hiding this comment.
i think instead of mentioning the installation of the typescript plugin directly, we can add a arc-ts directory and add the dependency and full app.arc there
mcansh
added
the
needs-response
|
@ryanblock can you make these adjustments? |
readme changes taken from #2213 as I can't push to that branch Signed-off-by: Logan McAnsh <logan@mcan.sh>
MichaelDeBoey
changed the title
README + dependencies
MichaelDeBoey
changed the title
README + dependenciesREADME + dependencies
|
@ryanblock Also make sure to rebase your branch onto latest |
|
@ryanblock #2332 got merged and implemented some README changes. Thank you 🙏🏼 |
|
@ryanblock Could you please rebase your branch onto latest |
MichaelDeBoey
added
needs-response
|
This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you have more information for us! 🙂 |
MichaelDeBoey
removed
the
needs-response
Closes: #